US Census Annual Population - Manifest fix#1858
US Census Annual Population - Manifest fix#1858niveditasing merged 8 commits intodatacommonsorg:masterfrom
Conversation
Summary of ChangesHello @HarishC727, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the data processing workflow for the US Census Annual Population dataset. It separates the download and processing steps of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily updates the manifest.json to separate the data download and processing steps, which is a good improvement for modularity. However, I've identified a critical issue in preprocess.py where the script fails if no input files are present. This should be addressed to make the script more robust, especially with the newly separated execution steps.
|
@HarishC727 : Please rectify comments as discussed. Also remove the redundant try except block for download_files fucntion |
|
LGTM |
|
/gcbrun |
@pulkeet-wq : Done. Removed the block and update the comments in script |
|
/gcbrun |
4 participants
No description provided.